Skip to content

Conversation

@HageMaster3108
Copy link
Contributor

@HageMaster3108 HageMaster3108 commented Dec 1, 2025

This changes the demo server to expose the http and websocket services under the same port, so we can easily expose it using ngrok, nginx etc.

Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@kylecarbs
Copy link
Member

fmt is my fault on main - will merge once build/test pass.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@HageMaster3108 HageMaster3108 marked this pull request as draft December 1, 2025 22:55
@HageMaster3108 HageMaster3108 marked this pull request as ready for review December 1, 2025 23:25
@gregsadetsky gregsadetsky mentioned this pull request Dec 2, 2025
@sreya
Copy link
Contributor

sreya commented Dec 4, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sreya
Copy link
Contributor

sreya commented Dec 4, 2025

@HageMaster3108 could you run bun run fmt:fix to fix up formatting? I'll get this merged afterwards.

@HageMaster3108
Copy link
Contributor Author

@HageMaster3108 could you run bun run fmt:fix to fix up formatting? I'll get this merged afterwards.

Done

@sreya sreya merged commit b0028ee into coder:main Dec 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants